2018		Nankana as Karam Singh 'Karma'
2018		Manto as Sakina's father - Sirajuddin

2014

2010

as Major Kuldeep Singh

2009

as Prem

2006

as Waris Shah

2004		Veer-Zaara as Gurdas Maan
2004		Des Hoyaa Pardes as Gurshaaan Singh Somal

2002

as Amar

2000

as Bhagat Singh

1999

as Boota Singh

1994

1991

as Shankar

1986

as Channa

1984

as Amarjeet

1982

as Gurdit

2004

… Playback Singer

2003

… Playback Singer

1999		Sirf Tum … Playback Singer
1999		Shaheed-E-Mohabbat Boota Singh … Playback Singer

1984

… Music

2018

… Lyricist

2010

… Screenplay

1984

… Story

2010

… Producer

1984

… Director